-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installing requests[security] is failing #231
Comments
Hello, In order to use |
FWIW, this doesn't solve my problem when using the heroku-docker plugin.
|
@RyanBalfanz this buildpack is not used in the |
@kennethreitz, thanks for the reply. I was able to get heroku/python-getting-started working with Any idea when this buildpack will officially be supported? Or if it is even on the roadmap at all? |
@RyanBalfanz at this time, the At one point in time, during the first iteration, I did have the Python Docker image simply download and utilize this buildpack during its build. This worked well, and is certianly an option (you can look in the git history of the repository for an example Dockerfile to accomplish this). However — simply running effectively the entire build as a single step in Docker takes away from many of the benefits of using Docker in the first place — so, we decided as a team to build each Dockerfile minimally and from scratch. At this point in time, I personally assume (haven't looked at any numbers) that the Python Docker image isn't receiving any widespread usage, as it's still a fairly early-stage project. In the future, as Heroku's Docker story evolves, I'm sure much if not all of the above story will change. For example: support for Python 3 was added into the Python Docker Image just a few weeks ago — because a user (finally) requested it. |
@kennethreitz Got it, thanks! |
We have been using requests for a while in our app, and now recently found some situations where error messages were getting logged due to not having the correct environment for SSL. So we started using requests[security]. Deploys started failing after that with the following message:
After finding this PR https://github.com/heroku/heroku-buildpack-python/pull/172/files, I added
cffi
to our requirements.txt which fixed it. Just thought I would bring this up, maybe add requests[security] to the list of whitelisted dependencies that needcffi
.The text was updated successfully, but these errors were encountered: