Use local scope for variables in output helpers (#1719)

Since `read` defines the `line variable as global by default, meaning `line` was visible outside these functions.
heroku · Dec 12, 2024 · e74c46e · e74c46e
1 parent c4e4a4f
commit e74c46e
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/lib/output.sh b/lib/output.sh
@@ -40,6 +40,7 @@ function output::indent() {
 # EOF
 # ```
 function output::notice() {
+	local line
 	echo >&2
 	while IFS= read -r line; do
 		echo -e "${ANSI_BLUE} !     ${line}${ANSI_RESET}" >&2
@@ -58,6 +59,7 @@ function output::notice() {
 # EOF
 # ```
 function output::warning() {
+	local line
 	echo >&2
 	while IFS= read -r line; do
 		echo -e "${ANSI_YELLOW} !     ${line}${ANSI_RESET}" >&2
@@ -76,6 +78,7 @@ function output::warning() {
 # EOF
 # ```
 function output::error() {
+	local line
 	echo >&2
 	while IFS= read -r line; do
 		echo -e "${ANSI_RED} !     ${line}${ANSI_RESET}" >&2