Add the proper Nginx mime type for mjs files #737
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
dzuelke
added a commit
that referenced
this pull request
Jul 2, 2024
This is compliant with RFC 9239. The normal .js extension remains on application/javascript as defined in the OEM mime.types config. See https://trac.nginx.org/nginx/ticket/2216 for upstream change proposal. Closes #737 GUS-W-16142337
robinwo
pushed a commit
to robinwo/heroku-buildpack-php
that referenced
this pull request
Sep 13, 2024
This is compliant with RFC 9239. The normal .js extension remains on application/javascript as defined in the OEM mime.types config. See https://trac.nginx.org/nginx/ticket/2216 for upstream change proposal. Closes heroku#737 GUS-W-16142337
robinwo
pushed a commit
to robinwo/heroku-buildpack-php
that referenced
this pull request
Sep 13, 2024
This is compliant with RFC 9239. The normal .js extension remains on application/javascript as defined in the OEM mime.types config. See https://trac.nginx.org/nginx/ticket/2216 for upstream change proposal. Closes heroku#737 GUS-W-16142337
robinwo
pushed a commit
to robinwo/heroku-buildpack-php
that referenced
this pull request
Sep 13, 2024
This is compliant with RFC 9239. The normal .js extension remains on application/javascript as defined in the OEM mime.types config. See https://trac.nginx.org/nginx/ticket/2216 for upstream change proposal. Closes heroku#737 GUS-W-16142337
robinwo
pushed a commit
to robinwo/heroku-buildpack-php
that referenced
this pull request
Sep 13, 2024
This is compliant with RFC 9239. The normal .js extension remains on application/javascript as defined in the OEM mime.types config. See https://trac.nginx.org/nginx/ticket/2216 for upstream change proposal. Closes heroku#737 GUS-W-16142337
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HTML spec requires getting a content-type of
application/javascriptfor ES modules, rejecting them otherwise. And browsers are respecting this spec.As it is common to use the
.mjsfor ES modules (because of the convention introduced in node.js, which has also been adopted by some frontend packages when they want to start shipping a version using modules), having the right mime types for it in the nginx config is a must-have IMO.This matches the configuration used in the h5bp nginx configuration