-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve changelog entry for v119 #633
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I can clarify a bit, NPM_CONFIG_PRODUCTION
and YARN_PRODUCTION
are not a Heroku buildpack convention. They are the env vars used by each tools themselves.
The Node buildpack did set NPM_CONFIG_PRODUCTION=true
as a way of controlling npm, and a few users used this to determine that they were running on Heroku, but that was never the intended use. This led to this release causing issues for a few users.
CHANGELOG.md
Outdated
@@ -82,6 +82,7 @@ | |||
## v119 (2018-02-28) | |||
|
|||
- Install and prune devDependencies by default (#519) | |||
- Split `NPM_CONFIG_PRODUCTION` into `NPM_CONFIG_PRODUCTION` and `YARN_PRODUCTION` (for npm and Yarn respectively) (#519) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is more accurately phrased as:
No longer export NPM_CONFIG_PRODUCTION=true
by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re. #633 (comment), I was trying to communicate that potential usage of NPM_CONFIG_PRODUCTION=false
would have to be replaced with YARN_PRODUCTION=false
.
@jmorrell My perspective of this was that we were setting
Hmm, but they seem to be used by the buildpack, no? E.g. heroku-buildpack-nodejs/lib/dependencies.sh Line 187 in 5d1e6f7
|
Yes, if a user has set this to either |
I don't believe this was ever the way the buildpack worked. We never checked the npm env var when choosing whether or not to prune with yarn: https://github.com/heroku/heroku-buildpack-nodejs/pull/519/files#diff-b796d034e8c512aaeb727f89e3598620R97 Can you say more about this? |
I was inaccurate here. We were checking in |
As an aside: This whole change was necessary for users and eliminated a whole class of errors that used to plague support, but it was a nightmare to pull off with a minimum of disruption to existing users 😞 I'm sorry you're hitting issues updating |
Aha, you're right. We were specifying |
* upstream/master: Update changelog (#638) Add v140 to changelog (#640) Add metadata logging when the build fails (#630) Rename build-data module to metadata and update the callsites (#629) New module for running experiments (#631) Fix two issues with kvstore (#637) Also print the change warning when the build fails (#639) Add temporary warning about "run build" change (#636) Run the build script by default (#628) Update CHANGELOG.md (#635) Improve changelog entry for v119 (#633) Make breaking change warning header brighter
When we upgraded, things broke because
NPM_CONFIG_PRODUCTION
stopped working, however this was not a clear breaking change from the changelog. Thus, I would like to improve the changelog for other users who may also experience this.