Improvements to cache invalidation #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmorley
force-pushed
the
edmorley/cache-invalidation-improvements
branch
3 times, most recently
from
9f2ae86
to
1436a0b
Compare
colincasey
reviewed
Jun 20, 2024
edmorley
force-pushed
the
edmorley/cache-invalidation-improvements
branch
2 times, most recently
from
b64aa54
to
6a01b3a
Compare
Now:
- If the stack version file is missing, we don't assume the cached files
belong to the current stack (since that could cause breakage), and
instead invalidate the cache. (The cache actually offers little benefit
in practice for this buildpack, so invalidating is cheap.)
- The whole `${CACHE_DIR}/apt` directory is removed rather than
only the `${CACHE_DIR}/apt/cache` directory. This ensures the APT
indexes and other files from old stack versions are cleaned up too.
- Some build output logs have been adjusted to be more accurate.
- A test has been added for cache re-use, since it wasn't previously
tested.
These papercuts were noticed whilst working on:
heroku/heroku-buildpack-chrome-for-testing#21
edmorley
force-pushed
the
edmorley/cache-invalidation-improvements
branch
from
6a01b3a
to
59d347d
Compare
colincasey
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now:
${CACHE_DIR}/aptdirectory is removed rather than only the${CACHE_DIR}/apt/cachedirectory. This ensures the APT indexes and other files from old stack versions are cleaned up too.These papercuts were noticed whilst working on:
heroku/heroku-buildpack-chrome-for-testing#21
GUS-W-16045851.