Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redirect stderr to stdout for apt-get update #122

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Redirect stderr to stdout for apt-get update #122

merged 1 commit into from
Mar 28, 2024

Conversation

colincasey
Copy link
Contributor

The warning emitted by apt-get update prevents the test suite from being able to assertCapturedSuccess so redirecting it from stderr to stdout.

@colincasey colincasey self-assigned this Mar 20, 2024
@colincasey colincasey requested a review from a team as a code owner March 20, 2024 16:26
@colincasey colincasey requested review from dzuelke and removed request for a team March 20, 2024 16:26
@colincasey colincasey added the skip changelog Skip the check-changelog check label Mar 20, 2024
@colincasey colincasey mentioned this pull request Mar 20, 2024
Merged
Base automatically changed from add_test_harness to master March 22, 2024 15:14
@colincasey colincasey merged commit e8f2707 into master Mar 28, 2024
3 checks passed
@colincasey colincasey deleted the dont_fail_on_update_warning branch March 28, 2024 13:44
Frzk pushed a commit to Scalingo/apt-buildpack that referenced this pull request May 13, 2024
@colincasey @Frzk
Redirect stderr to stdout for apt-get update (heroku#122)
35d00ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzuelke dzuelke dzuelke approved these changes

Assignees

@colincasey colincasey

Labels
skip changelog Skip the check-changelog check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colincasey @dzuelke