Fix before_deploy in tests #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneems
force-pushed
the
schneems/before_deploy_tests
branch
2 times, most recently
from
cee8573
to
533af67
Compare
The `setup!` calls `call_before_deploy` in the `run_ci` method, however it's called outside of the `in_directory` context so it accidentally commits the results to the current dir instead of the repo being tested against.
schneems
force-pushed
the
schneems/before_deploy_tests
branch
from
533af67
to
b53d7c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
setup!callscall_before_deployin therun_cimethod, however it's called outside of thein_directorycontext so it accidentally commits the results to the current dir instead of the repo being tested against.