Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apps:rename and apps:destroy incorrectly handles git remotes #3110

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

justinwilaby
Copy link
Contributor

fixes #3109

To test

  1. Add 1 or more remotes that point to the same app. e.g. heroku git:remote APP_NAME && heroku git:remote APP_NAME --remote heroku-dev` - This will add 2 remotes
  2. Verify heroku and heroku-dev exist and they both point to the same URL
  3. Run ./bin/run apps:rename OLD_APP_NAME NEW_APP_NAME with the cwd of your local git repo.
  4. Verify both remotes have changed git remote -v

@justinwilaby justinwilaby requested a review from a team as a code owner November 25, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

apps:rename removes the git remote instead of renaming it
1 participant