Improve pip package manager tests #256
Merged
+198
−147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmorley
added
skip changelog
edmorley
force-pushed
the
improve-pip-tests
branch
from
1737e8b
to
a96e243
Compare
Whilst writing the tests for the upcoming Poetry support, I made a few changes to the overall package manager testing strategy (such as using a testing buildpack to verify that at build time the tools and env vars are configured correctly) - which I've split out of the later PRs for easier review. In particular, the new testing buildpack added here is what helped me debug and locate this upstream lifecycle build time env vars bug (which would have broken apps when we switch to venvs shortly): buildpacks/lifecycle#1393 GUS-W-16617242.
edmorley
force-pushed
the
improve-pip-tests
branch
from
a96e243
to
9f6b176
Compare
Malax
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst writing the tests for the upcoming Poetry support, I made a few changes to the overall package manager testing strategy (such as using a testing buildpack to verify that at build time the tools and env vars are configured correctly) - which I've split out of the later PRs for easier review.
In particular, the new testing buildpack added here is what helped me debug and locate this upstream lifecycle build time env vars bug (which could have broken some build scenarios when we switch to venvs shortly):
buildpacks/lifecycle#1393
GUS-W-16617242.