Switch to consuming commons from the Ruby CNB main branch
#725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the feature branch no longer exists. This will fix Dependabot erroring out with: ``` Errored with the message "Dependabot couldn't fetch the branch/reference for commons" ```
Fixes: ``` error[E0432]: unresolved import `commons::fun_run` --> buildpacks/nodejs-npm-install/src/errors.rs:3:14 | 3 | use commons::fun_run::CmdError; | ^^^^^^^ could not find `fun_run` in `commons` ``` etc Which is due to: heroku/buildpacks-ruby#232
colincasey
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the feature branch no longer exists.
This will fix Dependabot erroring out with:
This also required adding
fun_runas an explicit dependency, due to:heroku/buildpacks-ruby#232
GUS-W-14513823.