Add sdk download retry logic #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runesoerensen
added
skip changelog
Malax
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
FWIW: I have some prior art for a more sophisticated solution should you ever need one: https://github.com/heroku/buildpacks-jvm/blob/b27cc75c2c5dac1841dd262edf3aadc8feb63ab5/shared-test/src/lib.rs
runesoerensen
force-pushed
the
add-sdk-download-retry-logic
branch
from
032d9f8
to
aaf09e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds simple retry logic when SDK downloads fail due to an I/O error, to better handle unexpected connection issues during downloads.
We may want to add additional logic in the future (to retry for instance HTTP 429 and HTTP 503 responses), or limit the I/O error retries to just connection resets or unexpected EOF. I've also only allowed one retry after 1 second, which we may also want to increase.
The
bullet_streamcrate was bumped to0.3.0to leverage schneems/bullet_stream#10.