Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add touchDragEnabled property to support disabling touch drag. #57

Merged
merged 2 commits into from
Mar 8, 2021
Merged

Add touchDragEnabled property to support disabling touch drag. #57

merged 2 commits into from
Mar 8, 2021

Conversation

grimmdude
Copy link
Contributor

Defaults to true, so will not affect existing applications.

Usage

<DatePickerCalendar date={date} onDateChange={setDate} locale={enGB} touchDragEnabled={false} />

Closes #34

@grimmdude
Copy link
Contributor Author

Bumping this, any interest in merging @hernansartorio?

hernansartorio
hernansartorio reviewed Mar 7, 2021
View reviewed changes
Copy link
Owner

@hernansartorio hernansartorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @grimmdude, sorry for the delay. Yes, this is great, thank you!

Just a minor comment. Plus, it would be good to replicate the prop on DateRangePicker and DateRangePickerCalendar as well for consistency.

hernansartorio
hernansartorio reviewed Mar 7, 2021
View reviewed changes
src/useGrid.js Outdated Show resolved Hide resolved
@grimmdude
Copy link
Contributor Author

Hey @hernansartorio,

Awesome thanks, good call I've made these changes ✅

hernansartorio
hernansartorio approved these changes Mar 8, 2021
View reviewed changes
Copy link
Owner

@hernansartorio hernansartorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@hernansartorio hernansartorio merged commit 3fe7930 into hernansartorio:master Mar 8, 2021
@grimmdude grimmdude deleted the disable_touch_drag branch March 9, 2021 00:11
@Zunawe Zunawe mentioned this pull request Jan 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hernansartorio hernansartorio hernansartorio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove calendar swipe up/down navigation for mobile devices
2 participants
@grimmdude @hernansartorio