Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CoreLocal repr(C) #705

Merged
merged 1 commit into from
Apr 16, 2023
Merged

Make CoreLocal repr(C) #705

merged 1 commit into from
Apr 16, 2023

Conversation

nathanwhyte
Copy link
Contributor

@nathanwhyte nathanwhyte commented Apr 9, 2023

Addresses #686

Add the repr(C) layout specifier to the CoreLocal struct.

@nathanwhyte nathanwhyte closed this Apr 9, 2023
@nathanwhyte nathanwhyte reopened this Apr 9, 2023
@mkroening mkroening self-requested a review April 10, 2023 02:53
@mkroening mkroening self-assigned this Apr 10, 2023
Copy link
Member

@mkroening mkroening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

bors r+

bors bot added a commit that referenced this pull request Apr 16, 2023
705: Make CoreLocal repr(C) r=mkroening a=nathanwhyte

Addresses #686

Add the `repr(C)` layout specifier to the CoreLocal struct.

Co-authored-by: Nathan Whyte <[email protected]>
@bors
Copy link
Contributor

bors bot commented Apr 16, 2023

Build failed:

@mkroening
Copy link
Member

Oh, no. CI currently fails because of the current, hermit-entry version bump dance. This should be fixed in the next couple of days.

CC: @stlankes

@mkroening
Copy link
Member

As a side note: in the future, we might want to explore making this repr(rust) again (#710). But this fix is definitely needed for correctness meanwhile.

@mkroening
Copy link
Member

bors retry

@bors
Copy link
Contributor

bors bot commented Apr 16, 2023

@bors bors bot merged commit 837b76e into hermit-os:master Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants