Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove spinlock syscalls #656

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

mkroening
Copy link
Member

@mkroening mkroening commented Feb 14, 2023

This is only used in hermit/mailbox.h, which is only used in lwip/src/include/arch/sys_arch.h.

@mkroening mkroening changed the title Remove spinlock syscalls feat: remove spinlock syscalls Apr 24, 2024
@CarlWachter
Copy link
Contributor

LGTM, since only lwip uses this feature and hermit-playground is removing lwip.

@mkroening mkroening marked this pull request as ready for review May 2, 2024 11:53
@mkroening
Copy link
Member Author

LGTM, since only lwip uses this feature and hermit-playground is removing lwip.

Are they already removed? We should wait until then. :)

Copy link
Contributor

@CarlWachter CarlWachter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jounathaen
Copy link
Member

This is ready to be merged now, right?

@CarlWachter
Copy link
Contributor

This is ready to be merged now, right?

Jep

@mkroening mkroening assigned mkroening and unassigned CarlWachter Jun 24, 2024
Signed-off-by: Martin Kröning <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants