Ensure CpuFrequency is never explicitly set to zero #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschwe
force-pushed
the
bugfix/prevent-zero-cpu-frequency
branch
from
4857b43 to
510f546
Compare
detect_from_cpuid could previously set CpuFrequency to zero. To ensure that this doesn't happen all detect methods set mhz and CpuFrequencySources via a helper method that ensures that mhz is never explicitly set to zero (apart from the creation of the object)
jschwe
force-pushed
the
bugfix/prevent-zero-cpu-frequency
branch
from
510f546 to
5faf34d
Compare
|
Yes, the idea to introduce |
simonschoening
pushed a commit
to simonschoening/libhermit-rs
that referenced
this pull request
Aug 26, 2021
…requency Ensure CpuFrequency is never explicitly set to zero
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
detect_from_cpuid could previously set CpuFrequency to zero.
To ensure that this doesn't happen all detect methods set
mhz and CpuFrequencySources via a helper method that ensures
that mhz is never explicitly set to zero (apart from the
creation of the object)