Fix broken rdrand implementation #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_rdrand{32,64}_step returns 1 on success and zero on failure. See:
https://software.intel.com/sites/landingpage/IntrinsicsGuide/#text=_rdrand64_step&expand=4539
This means that the current implementation will actually hang on most processors:
https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=716f8f6a77ab6be76800ff7ee5d37970
This fixes the implementation to use the reccomdendation from the Intel SDM.
Signed-off-by: Joe Richey <[email protected]>
|
bors r+ |
simonschoening
pushed a commit
to simonschoening/libhermit-rs
that referenced
this pull request
Aug 26, 2021
154: Fix broken rdrand implementation r=stlankes a=josephlr
_rdrand{32,64}_step returns 1 on success and zero on failure. See:
https://software.intel.com/sites/landingpage/IntrinsicsGuide/#text=_rdrand64_step&expand=4539
This means that the current implementation will actually hang on most processors:
https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=716f8f6a77ab6be76800ff7ee5d37970
This fixes the implementation to use the reccomdendation from the Intel SDM.
Signed-off-by: Joe Richey <[email protected]>
Co-authored-by: Joe Richey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_rdrand{32,64}_step returns 1 on success and zero on failure. See:
https://software.intel.com/sites/landingpage/IntrinsicsGuide/#text=_rdrand64_step&expand=4539
This means that the current implementation will actually hang on most processors:
https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=716f8f6a77ab6be76800ff7ee5d37970
This fixes the implementation to use the reccomdendation from the Intel SDM.
Signed-off-by: Joe Richey [email protected]