Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(virtqueue): make several types smaller #1241

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

mkroening
Copy link
Member

No description provided.

Virtqueue number and queue size are `le16`.
Queue size corresponds to number of descriptors.

Signed-off-by: Martin Kröning <[email protected]>
Copy link
Contributor

@cagatay-y cagatay-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any issue regarding the first commit. For the second one, I don't think any of the two states of the wrap counter are more true or false than the other but if it has an performance advantage I don't see an issue with it too.

@mkroening
Copy link
Member Author

For the second one, I don't think any of the two states of the wrap counter are more true or false than the other

I changed it to a u8. 👍

@mkroening mkroening enabled auto-merge June 3, 2024 13:50
@mkroening mkroening added this pull request to the merge queue Jun 3, 2024
Merged via the queue into main with commit 1bfcb44 Jun 3, 2024
13 checks passed
@mkroening mkroening deleted the virtqueue-small-types branch June 10, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants