add support of a unix-like poll function #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stlankes
force-pushed
the
poll
branch
2 times, most recently
from
7c587ac to
16f5622
Compare
stlankes
force-pushed
the
poll
branch
3 times, most recently
from
7de10c1 to
9a31a04
Compare
|
@mkroening Now, you can review the PR. I added some async lock to reduce the blocking time. |
stlankes
force-pushed
the
poll
branch
3 times, most recently
from
ac4f22f to
e41b14a
Compare
poll() examines a set of file descriptors to see if some of them are ready for I/O or if certain events have occurred on them. The currenty implementation is using an asynchronous function to check all file descriptors.
according to the POSIX standard, POLLNVAL should be returned, if the socket is already closed.
This removes a blocking function within the async function `poll_fds`.
in cace, the NIC is already used by a task, the calling of poll function isn't required.
- using async_locks to reduce the blocking time
|
This is awesome 🎆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
poll()examines a set of file descriptors to see if some of them are ready for I/O or if certain events have occurred on them. The currenty implementation is using an asynchronous function to check all file descriptors.This PR should solve smol-rs/polling#177
Currently, the PR doesn't support file descriptors, which points to the uhyve file system.