feat: remove toolchain.sh in favor of Dockerfile
#33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkroening
force-pushed
the
impl
branch
5 times, most recently
from
cc3ddba to
77db1f8
Compare
mkroening
changed the title
Dockerfile and toolchain.sh
mkroening
force-pushed
the
impl
branch
7 times, most recently
from
84d3ce6 to
c7488d7
Compare
mkroening
changed the title
Dockerfile and toolchain.shtoolchain.sh
mkroening
changed the title
toolchain.shtoolchain.sh in favor of Dockerfile
mkroening
force-pushed
the
impl
branch
2 times, most recently
from
df9e825 to
9ef3ed8
Compare
|
@stlankes, @CarlWachter, is this approach okay with you? Do Docker images work for you in principle, or do you need In my experience, focusing on Docker should make this easier for everyone in general. |
mkroening
requested review from
CarlWachter and
stlankes
and removed request for
CarlWachter
|
This seems like a good approach to me. The toolchain.sh usually caused a lot of headaches anyways. |
|
I messed up the force-pushes and GitHub won't let me reopen: #42 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should make iterating on the toolchain's components much easier and faster. One can just point the
ADDlayers to local sources for development as needed.In the future, we could also replace this manual
gccbootstrapping with crosstool-NG, but I have not had a closer look yet.Related PRs:
FLAGS_FOR_TARGET#38