Skip to content

Commit

Permalink
roachprod: remove cdrb_test for nightly
Browse files Browse the repository at this point in the history
Previously, we included the `--crdb_test` build flag for `roachprod`. This
binary is only built to be used as part of the `roachprod update` logic. Adding
the flag causes roachprod to produce a log of metamorphic vars which is not
expected behaviour when using it as a CLI tool.

Informs: cockroachdb#124592

Epic: None
Release note: None
  • Loading branch information
herkolategan committed Nov 27, 2024
1 parent 97965d4 commit db6d9c2
Showing 1 changed file with 6 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,12 @@ case "$component" in
artifacts=("pkg/cmd/roachtest/roachtest_/roachtest:bin/roachtest.$os-$arch")
;;
roachprod)
# Roachprod binary.
bazel_args=(//pkg/cmd/roachprod --crdb_test)
# Roachprod binary. This binary is only built here to support the logic
# behind `roachprod update`. Hence, we do not need to add `--crdb_test` to
# the build command as we do for `roachtest`. Adding the build flag causes
# the binary to log metamorphic vars on each command invocation, which is
# not ideal from a user experience perspective.
bazel_args=(//pkg/cmd/roachprod)
artifacts=("pkg/cmd/roachprod/roachprod_/roachprod:bin/roachprod.$os-$arch")
;;
*)
Expand Down

0 comments on commit db6d9c2

Please sign in to comment.