Skip to content

Commit

Permalink
util/mon: disable recently added assertion for now
Browse files Browse the repository at this point in the history
There are some more issues to address (probably around the server
shutdown), so let's disable the recently added assertion that all
short-living monitors are stopped when the parent is stopped.

Release note: None
  • Loading branch information
yuzefovich committed May 30, 2024
1 parent 04ecf34 commit ab7a048
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions pkg/util/mon/bytes_usage.go
Original file line number Diff line number Diff line change
Expand Up @@ -653,12 +653,13 @@ func (mm *BytesMonitor) doStop(ctx context.Context, check bool) {
// Ignore mm itself if it is short-living.
numShortLiving--
}
if numShortLiving > 0 {
panic(errors.AssertionFailedf(
"found %d short-living non-stopped monitors in %s\n%s",
numShortLiving, mm.name, sb.String(),
))
}
// TODO(#124848): uncomment this.
//if numShortLiving > 0 {
// panic(errors.AssertionFailedf(
// "found %d short-living non-stopped monitors in %s\n%s",
// numShortLiving, mm.name, sb.String(),
// ))
//}
}
}

Expand Down

0 comments on commit ab7a048

Please sign in to comment.