Merge cockroachdb#131910

131910: raft: clean up TestMsgAppFlowControl r=iskettaneh a=iskettaneh A recent commit removed the nested message checks in raft_flow_control_test. However One part was missed, and this commit fixes that. Epic: None Release note: None Co-authored-by: Ibrahim Kettaneh <[email protected]>
herkolategan · Oct 4, 2024 · 8fac0b6 · 8fac0b6
2 parents 42ed8a3 + 1ee08f5
commit 8fac0b6
Showing 1 changed file with 0 additions and 5 deletions.
diff --git a/pkg/raft/raft_flow_control_test.go b/pkg/raft/raft_flow_control_test.go
@@ -145,11 +145,6 @@ func TestMsgAppFlowControl(t *testing.T) {
 							r.tick()
 						}
 						ms := r.readMessages()
-						if len(ms) != 3 || ms[0].Type != pb.MsgHeartbeat || ms[1].Type != pb.MsgFortifyLeader ||
-							ms[2].Type != pb.MsgApp || len(ms[2].Entries) != 0 {
-							t.Fatalf("#%d.%d: len(ms) == %d, want 3 messages including one empty MsgApp",
-								tt, i, len(ms))
-						}
 						require.Len(t, ms, 3)
 						require.Equal(t, ms[0].Type, pb.MsgHeartbeat)
 						require.Equal(t, ms[1].Type, pb.MsgFortifyLeader)