Skip to content

Commit

Permalink
roachprod: remove cdrb_test for nightly
Browse files Browse the repository at this point in the history
Previously, we included the `--crdb_test` build flag for `roachprod`. This
binary is only built to be used as part of the `roachprod update` logic. Adding
the flag causes roachprod to produce a log of metamorphic vars which is not
expected behaviour when using it as a CLI tool.

Informs: cockroachdb#124592

Epic: None
Release note: None
  • Loading branch information
herkolategan committed Nov 27, 2024
1 parent 97965d4 commit 5d920b3
Showing 1 changed file with 6 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,12 @@ case "$component" in
;;
roachprod)
# Roachprod binary.
bazel_args=(//pkg/cmd/roachprod --crdb_test)
# This binary is built to support the logic behind `roachprod update`.
# Hence, we do not need to add `--crdb_test` to the build args as we do
# for `roachtest`. Adding the build flag causes the binary to log
# metamorphic vars on each command invocation, which is not ideal from a
# user experience perspective.
bazel_args=(//pkg/cmd/roachprod)
artifacts=("pkg/cmd/roachprod/roachprod_/roachprod:bin/roachprod.$os-$arch")
;;
*)
Expand Down

0 comments on commit 5d920b3

Please sign in to comment.