Skip to content

Commit

Permalink
spanconfigtestcluster: don't set SkipWaitingForMVCCGC
Browse files Browse the repository at this point in the history
This knob is no longer needed, and it seems to cause a rare flake with
an error `relation "[107]" does not exist`. This is because part of the
spanconfigsplitter test is to lookup a dropped a descriptor, and with
the knob set, the descriptor can be removed too quickly for the test to
be able to look at it.

Release note: None
  • Loading branch information
rafiss committed May 31, 2024
1 parent 64bd4bb commit 5613e5b
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,10 @@ func (h *Handle) InitializeTenant(ctx context.Context, tenID roachpb.TenantID) *
tenantState.cleanup = func() {} // noop
} else {
serverGCJobKnobs := testServer.SystemLayer().TestingKnobs().GCJob
tenantGCJobKnobs := sql.GCJobTestingKnobs{SkipWaitingForMVCCGC: true}
// Copy the GC job knobs from the server to the tenant.
tenantGCJobKnobs := sql.GCJobTestingKnobs{}
if serverGCJobKnobs != nil {
tenantGCJobKnobs = *serverGCJobKnobs.(*sql.GCJobTestingKnobs)
tenantGCJobKnobs.SkipWaitingForMVCCGC = true
}
tenantArgs := base.TestTenantArgs{
TenantID: tenID,
Expand Down

0 comments on commit 5613e5b

Please sign in to comment.