This repository has been archived by the owner on Mar 8, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 197
MAPSJS-2660: Clean MapViewUtils namespace #2302
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomicsulfate
force-pushed
the
MAPSJS-2660_CleanMapViewUtils
branch
3 times, most recently
from
August 31, 2021 10:28
cf9ee56
to
9045545
Compare
Codecov Report
@@ Coverage Diff @@
## master #2302 +/- ##
==========================================
+ Coverage 68.29% 68.30% +0.01%
==========================================
Files 317 319 +2
Lines 27795 27809 +14
Branches 6230 6233 +3
==========================================
+ Hits 18982 18995 +13
- Misses 8813 8814 +1
Continue to review full report at Codecov.
|
ThFischer
reviewed
Sep 2, 2021
0x4000000000000, | ||
0x8000000000000, | ||
0x10000000000000 | ||
]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More efficient:
let val = .5;
export const powerOfTwo = Array(53).fill(0).map(() => val *= 2);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch!
Signed-off-by: Andres Mandado <[email protected]>
Signed-off-by: Andres Mandado <[email protected]>
Signed-off-by: Andres Mandado <[email protected]>
Signed-off-by: Andres Mandado <[email protected]>
Also, move old test to the right place. Signed-off-by: Andres Mandado <[email protected]>
atomicsulfate
force-pushed
the
MAPSJS-2660_CleanMapViewUtils
branch
from
September 2, 2021 15:18
9045545
to
5e1a5fc
Compare
ThFischer
approved these changes
Sep 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove from MapViewUtils functions that are unrelated to MapView.
MapViewUtils namespace has now only functions related to view transformations, camera setup, and view bounds computation.