This repository has been archived by the owner on Mar 8, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 197
MAPSJS-2660: Remove Orthographic camera from ClipPlanesEvaluator. #2251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomicsulfate
changed the base branch from
master
to
MAPSJS-2660_FixNearPlaneSphere
July 30, 2021 08:53
nzjony
reviewed
Jul 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and thanks for the removal, just some minor features.
atomicsulfate
force-pushed
the
MAPSJS-2660_FixNearPlaneSphere
branch
3 times, most recently
from
August 2, 2021 08:01
98d5448
to
117daf9
Compare
atomicsulfate
force-pushed
the
MAPSJS-2660_RemoveOrthoCamera
branch
from
August 2, 2021 08:10
b01e81e
to
011f0b5
Compare
atomicsulfate
force-pushed
the
MAPSJS-2660_FixNearPlaneSphere
branch
2 times, most recently
from
August 2, 2021 10:16
5d10d76
to
4d84b6c
Compare
Not supported by the rest of harp. Signed-off-by: Andres Mandado <[email protected]>
atomicsulfate
force-pushed
the
MAPSJS-2660_RemoveOrthoCamera
branch
from
August 2, 2021 12:28
c9f3dae
to
96f592f
Compare
@harpgl-bot retest this please |
retest this please |
atomicsulfate
force-pushed
the
MAPSJS-2660_RemoveOrthoCamera
branch
from
August 2, 2021 13:00
96f592f
to
1fb0624
Compare
Codecov Report
@@ Coverage Diff @@
## master #2251 +/- ##
==========================================
+ Coverage 67.79% 67.87% +0.08%
==========================================
Files 313 313
Lines 27690 27665 -25
Branches 6198 6191 -7
==========================================
+ Hits 18773 18779 +6
+ Misses 8917 8886 -31
Continue to review full report at Codecov.
|
Signed-off-by: Andres Mandado <[email protected]>
atomicsulfate
force-pushed
the
MAPSJS-2660_RemoveOrthoCamera
branch
from
August 2, 2021 14:06
1fb0624
to
3550687
Compare
nzjony
reviewed
Aug 2, 2021
Signed-off-by: Andres Mandado <[email protected]>
nzjony
approved these changes
Aug 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.