Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

MAPSJS-2660: Remove Orthographic camera from ClipPlanesEvaluator. #2251

Merged
merged 3 commits into from
Aug 2, 2021
Merged

MAPSJS-2660: Remove Orthographic camera from ClipPlanesEvaluator. #2251

merged 3 commits into from
Aug 2, 2021

Conversation

atomicsulfate
Copy link
Collaborator

No description provided.

@atomicsulfate atomicsulfate changed the base branch from master to MAPSJS-2660_FixNearPlaneSphere July 30, 2021 08:53
nzjony
nzjony reviewed Jul 30, 2021
View reviewed changes
Copy link
Member

@nzjony nzjony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and thanks for the removal, just some minor features.

@here/harp-mapview/lib/ClipPlanesEvaluator.ts Outdated Show resolved Hide resolved
@here/harp-mapview/lib/ClipPlanesEvaluator.ts Outdated Show resolved Hide resolved
@here/harp-mapview/lib/ClipPlanesEvaluator.ts Outdated Show resolved Hide resolved
@atomicsulfate atomicsulfate force-pushed the MAPSJS-2660_FixNearPlaneSphere branch 3 times, most recently from 98d5448 to 117daf9 Compare August 2, 2021 08:01
@atomicsulfate atomicsulfate force-pushed the MAPSJS-2660_FixNearPlaneSphere branch 2 times, most recently from 5d10d76 to 4d84b6c Compare August 2, 2021 10:16
Base automatically changed from MAPSJS-2660_FixNearPlaneSphere to master August 2, 2021 12:26
@atomicsulfate
MAPSJS-2660: Remove orthographic camera support in ClipPlanesEvaluator.
574c2d6 
Not supported by the rest of harp.

Signed-off-by: Andres Mandado <[email protected]>
@atomicsulfate
Copy link
Collaborator Author

@harpgl-bot retest this please

@atomicsulfate
Copy link
Collaborator Author

retest this please

@codecov
Copy link

codecov bot commented Aug 2, 2021 •
edited
Loading

Codecov Report

Merging #2251 (dffd09e) into master (8ecd5f7) will increase coverage by 0.08%.
The diff coverage is 62.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2251      +/-   ##
==========================================
+ Coverage   67.79%   67.87%   +0.08%     
==========================================
  Files         313      313              
  Lines       27690    27665      -25     
  Branches     6198     6191       -7     
==========================================
+ Hits        18773    18779       +6     
+ Misses       8917     8886      -31
Impacted Files Coverage Δ
@here/harp-mapview/lib/ClipPlanesEvaluator.ts 72.13% <62.06%> (+7.09%) ⬆️
@here/harp-mapview/lib/MapMaterialAdapter.ts 92.85% <0.00%> (+0.71%) ⬆️
@here/harp-mapview/lib/VisibleTileSet.ts 79.82% <0.00%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ecd5f7...dffd09e. Read the comment docs.

@atomicsulfate atomicsulfate merged commit a3131f6 into master Aug 2, 2021
@atomicsulfate atomicsulfate deleted the MAPSJS-2660_RemoveOrthoCamera branch August 2, 2021 16:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nzjony nzjony nzjony approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atomicsulfate @nzjony