This repository has been archived by the owner on Mar 8, 2023. It is now read-only.
HARP-15773 Fixes VisibleTileSet::markTilesDirty bug #2217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically, if we called this while the tile was still loading, then the execution of the tile.load method would use the existing donePromise in the BaseTileLoader We fix this by cancelling the TileLoader before requesting a new re-load Signed-off-by: Jonathan Stichbury <[email protected]>
AndriiHeonia
reviewed
Jun 9, 2021
Signed-off-by: Jonathan Stichbury <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2217 +/- ##
=======================================
Coverage 66.65% 66.65%
=======================================
Files 312 312
Lines 27755 27756 +1
Branches 6203 6204 +1
=======================================
+ Hits 18500 18502 +2
+ Misses 9255 9254 -1
Continue to review full report at Codecov.
|
AndriiHeonia
approved these changes
Jun 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.