Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

HARP-15031 Move boxes up by half the height to ensure that they sit on top of the buildings #2188

Merged
merged 1 commit into from
May 17, 2021

Conversation

nzjony
Copy link
Member

@nzjony nzjony commented May 6, 2021

Thank you for contributing to harp.gl!

Before requesting a pull request, please remember to check the following documents:

If you are adding new functionality we would highly appreciate if you can describe what is the capability you are adding and even better if you can add some examples. Please also remember to add tests for it.

CI Check

Our bots will check whether your PR can be directly integrated into the mainline. We have some internal integration tests running on the background, our bots will inform you of the next steps and someone from our team will take a look and help if needed!

And please do not forget to sign-off your commit! You can read more about DCO here. But, in short, you just need to use git commit -s or append --signoff when you are committing to the repo.

Happy contributing!

…n top of the buildings

Signed-off-by: Jonathan Stichbury <[email protected]>
@nzjony nzjony requested a review from FraukeF May 6, 2021 13:54
@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #2188 (31f2dc7) into master (b63d78e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2188   +/-   ##
=======================================
  Coverage   66.64%   66.64%           
=======================================
  Files         312      312           
  Lines       27745    27748    +3     
  Branches     6199     6201    +2     
=======================================
+ Hits        18490    18492    +2     
- Misses       9255     9256    +1     
Impacted Files Coverage Δ
@here/harp-mapview/lib/VisibleTileSet.ts 79.77% <0.00%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b63d78e...31f2dc7. Read the comment docs.

@nzjony nzjony merged commit 50358bf into master May 17, 2021
@nzjony nzjony deleted the HARP-15031 branch May 17, 2021 13:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants