Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

HARP-13229: Fix possible precision issues when converting coords from world to local space #2101

Merged
merged 2 commits into from
Feb 9, 2021

Conversation

robertoraggi
Copy link
Member

There is a precision issue and the clipping fails to correctly
classify the inner rings of clipped polygons at level 2.

@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #2101 (1203dc7) into master (a2a323d) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2101      +/-   ##
==========================================
- Coverage   67.22%   67.21%   -0.01%     
==========================================
  Files         297      297              
  Lines       26380    26380              
  Branches     5963     5963              
==========================================
- Hits        17733    17731       -2     
- Misses       8647     8649       +2     
Impacted Files Coverage Δ
@here/harp-vectortile-datasource/lib/OmvUtils.ts 84.90% <100.00%> (ø)
...vectortile-datasource/lib/VectorTileDataEmitter.ts 66.89% <0.00%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2a323d...9e8a0a9. Read the comment docs.

@robertoraggi robertoraggi changed the title HARP-13229: Add test to reproduce the issue when clipping tiles at level 2 HARP-13229: Fix precision possible precision issues when converting coords from world to local space Feb 5, 2021
@robertoraggi robertoraggi changed the title HARP-13229: Fix precision possible precision issues when converting coords from world to local space HARP-13229: Fix possible precision issues when converting coords from world to local space Feb 5, 2021
@robertoraggi
Copy link
Member Author

rebase please

…vel 2

There is a precision issue and the clipping fails to correctly
classify the inner rings of clipped polygons at level 2.

Signed-off-by: Roberto Raggi <[email protected]>
Coordinates converted to local tile must respect the tile precision
defined by the `extents` attribute.

Signed-off-by: Roberto Raggi <[email protected]>
@github-actions
Copy link

github-actions bot commented Feb 9, 2021

Rebase succeeded.

@robertoraggi robertoraggi merged commit 5fc1232 into master Feb 9, 2021
@robertoraggi robertoraggi deleted the HARP-13229 branch February 9, 2021 10:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants