This repository has been archived by the owner on Mar 8, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 197
HARP-13901: Fix THREE.Line and THREE.LineSegments picking. #2075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomicsulfate
force-pushed
the
HARP-13901_FixLinePicking
branch
2 times, most recently
from
January 27, 2021 11:07
f2219bd
to
ab2580a
Compare
atomicsulfate
force-pushed
the
HARP-13901_FixLinePicking
branch
from
January 28, 2021 13:13
ab2580a
to
2a0a3af
Compare
Codecov Report
@@ Coverage Diff @@
## master #2075 +/- ##
==========================================
+ Coverage 66.81% 67.13% +0.32%
==========================================
Files 297 297
Lines 26378 26379 +1
Branches 5969 5964 -5
==========================================
+ Hits 17624 17710 +86
+ Misses 8754 8669 -85
Continue to review full report at Codecov.
|
FraukeF
reviewed
Jan 29, 2021
atomicsulfate
force-pushed
the
HARP-13901_FixLinePicking
branch
from
January 29, 2021 12:32
5cbe5c6
to
ce2636c
Compare
FraukeF
reviewed
Jan 29, 2021
FraukeF
previously approved these changes
Jan 29, 2021
retest this please |
@harpgl-bot retest this please |
Raycaster must specify a threshold distance between ray and line.
Also, some cleaning in MapViewPoints.
Not public API anymore.
atomicsulfate
force-pushed
the
HARP-13901_FixLinePicking
branch
from
February 1, 2021 08:57
a656b7f
to
845286a
Compare
@harpgl-bot retest this please |
FraukeF
approved these changes
Feb 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raycaster must specify a threshold distance between ray and line.