Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

HARP-13901: Fix THREE.Line and THREE.LineSegments picking. #2075

Merged
merged 5 commits into from
Feb 1, 2021

Conversation

atomicsulfate
Copy link
Collaborator

Raycaster must specify a threshold distance between ray and line.

@atomicsulfate atomicsulfate force-pushed the HARP-13901_FixLinePicking branch 2 times, most recently from f2219bd to ab2580a Compare January 27, 2021 11:07
@atomicsulfate atomicsulfate marked this pull request as ready for review January 27, 2021 11:07
@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

Merging #2075 (31f6b68) into master (c4790fb) will increase coverage by 0.32%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2075      +/-   ##
==========================================
+ Coverage   66.81%   67.13%   +0.32%     
==========================================
  Files         297      297              
  Lines       26378    26379       +1     
  Branches     5969     5964       -5     
==========================================
+ Hits        17624    17710      +86     
+ Misses       8754     8669      -85     
Impacted Files Coverage Δ
@here/harp-mapview/lib/MapViewPoints.ts 9.25% <0.00%> (+1.56%) ⬆️
@here/harp-mapview/lib/MapObjectAdapter.ts 87.71% <100.00%> (ø)
@here/harp-mapview/lib/MapView.ts 73.46% <100.00%> (-0.09%) ⬇️
@here/harp-mapview/lib/PickHandler.ts 82.31% <100.00%> (+7.31%) ⬆️
@here/harp-mapview/lib/PickingRaycaster.ts 100.00% <100.00%> (ø)
...e/harp-mapview/lib/geometry/TileGeometryCreator.ts 71.75% <100.00%> (+1.10%) ⬆️
@here/harp-mapview/lib/Utils.ts 81.52% <0.00%> (+0.13%) ⬆️
...ere/harp-text-canvas/lib/rendering/TextGeometry.ts 73.02% <0.00%> (+0.46%) ⬆️
@here/harp-vectortile-datasource/lib/Ring.ts 100.00% <0.00%> (+2.56%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99b41a3...845286a. Read the comment docs.

@here/harp-mapview/lib/MapView.ts Outdated Show resolved Hide resolved
@here/harp-mapview/lib/MapView.ts Outdated Show resolved Hide resolved
FraukeF
FraukeF previously approved these changes Jan 29, 2021
@nzjony
Copy link
Member

nzjony commented Feb 1, 2021

retest this please

@atomicsulfate
Copy link
Collaborator Author

@harpgl-bot retest this please

@atomicsulfate
Copy link
Collaborator Author

@harpgl-bot retest this please

@atomicsulfate atomicsulfate merged commit b3029fe into master Feb 1, 2021
@atomicsulfate atomicsulfate deleted the HARP-13901_FixLinePicking branch February 1, 2021 10:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants