This repository has been archived by the owner on Mar 8, 2023. It is now read-only.
MINOR: Relates to #2019, fix broken storageLevelOffset #2047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@here/harp-mapview/lib/DataSource.ts
Outdated
| @@ -63,6 +63,7 @@ export interface DataSourceOptions { | |||
| maxDisplayLevel?: number; | |||
| /** | |||
| * Storage level offset applied to this `DataSource`. | |||
| * @default 0 | |||
There was a problem hiding this comment.
Isn't the default "datasource dependent"? e.g. in HereWebTileDataSource.ts the default seem to be -1.
Also, the correct tag is @defaultValue https://api-extractor.com/pages/tsdoc/tag_defaultvalue/
There was a problem hiding this comment.
Yes, I refer to the DataSource class itself, which defaults to 0. But I can remove if you prefer?
Signed-off-by: Jonathan Stichbury <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2047 +/- ##
==========================================
+ Coverage 66.53% 66.62% +0.09%
==========================================
Files 297 297
Lines 26331 26331
Branches 5949 5950 +1
==========================================
+ Hits 17519 17543 +24
+ Misses 8812 8788 -24
Continue to review full report at Codecov.
|
robertoraggi
approved these changes
Jan 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
storageLevelOffset was not passed through to DataSource correctly.