This repository has been archived by the owner on Mar 8, 2023. It is now read-only.
HARP-12928: Fix wrong text bounds on placement with multiple alignments. #2038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomicsulfate
force-pushed
the
HARP-12928_FixMultiPlacementCollision
branch
from
bb53471
to
2666b3a
Compare
|
@harpgl-bot retest this please |
Codecov Report
@@ Coverage Diff @@
## master #2038 +/- ##
=======================================
Coverage 66.62% 66.62%
=======================================
Files 297 297
Lines 26337 26326 -11
Branches 5945 5945
=======================================
- Hits 17546 17539 -7
+ Misses 8791 8787 -4
Continue to review full report at Codecov.
|
FraukeF
previously approved these changes
Jan 12, 2021
FraukeF
previously approved these changes
Jan 13, 2021
atomicsulfate
force-pushed
the
HARP-12928_FixMultiPlacementCollision
branch
from
f501e84
to
c7379ba
Compare
|
@harpgl-bot retest this please |
Changing old code that assumed that text state is shared among instances of the same line marker (roashield).
atomicsulfate
force-pushed
the
HARP-12928_FixMultiPlacementCollision
branch
from
c7379ba
to
8f01d63
Compare
|
@harpgl-bot retest this please |
FraukeF
approved these changes
Jan 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.