Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

MINOR: support DataSourceOptions in HereWebtileDataSource #2022

Merged
merged 2 commits into from
Jan 6, 2021
Merged

MINOR: support DataSourceOptions in HereWebtileDataSource #2022

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba15404
MINOR: support DataSourceOptions in HereWebtileDataSource
Jan 4, 2021
daa16d4
MINOR: Removing duplicate options
Jan 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion @here/harp-webtile-datasource/lib/HereWebTileDataSource.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import { Texture } from "three";
import {
WebTileDataProvider,
WebTileDataSource,
WebTileDataSourceOptions,
WebTileRenderingOptions
} from "./WebTileDataSource";

Expand All @@ -29,7 +30,7 @@ const textureLoader = new TextureLoader();
/**
* Options for {@link HereWebTileDataSource}.
*/
interface HereWebTileDataSourceOptions {
interface HereWebTileDataSourceOptions extends Omit<WebTileDataSourceOptions, "dataProvider"> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove resolution and renderingOptions, because they are part of WebTileDataSourceOptions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

/**
* Base URL.
*
Expand Down Expand Up @@ -405,6 +406,7 @@ export class HereWebTileDataSource extends WebTileDataSource {
*/
constructor(m_options: HereWebTileDataSourceParameters) {
super({
...m_options,
minDataLevel: 1,
maxDataLevel: 20,
resolution: m_options.resolution,
Expand Down