-
Notifications
You must be signed in to change notification settings - Fork 197
HARP-13329: Fix antimeridian cracks on ground planes. #2018
Conversation
36d2b9b
to
307afc9
Compare
Codecov Report
@@ Coverage Diff @@
## master #2018 +/- ##
==========================================
+ Coverage 66.26% 66.41% +0.15%
==========================================
Files 294 297 +3
Lines 26313 26336 +23
Branches 5930 5939 +9
==========================================
+ Hits 17435 17492 +57
+ Misses 8878 8844 -34
Continue to review full report at Codecov.
|
3fbe38b
to
4723867
Compare
4723867
to
d6259f4
Compare
d6259f4
to
02bf168
Compare
02bf168
to
e0d3fd4
Compare
@harpgl-bot retest this please |
82dbee1
to
98fef34
Compare
It does not include: - Fix for sphere projection. - Fix for cracks on HERE raster tile source images.
Use Float64Array for position attribute during geometry subdivision and coord transformation.
98fef34
to
fcb32cc
Compare
Add unit tests for ground plane generation.
fcb32cc
to
1d92354
Compare
); | ||
|
||
if (!shouldSubdivide) { | ||
return new THREE.Mesh(geometry, material); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to convert the Float64Array back to Float32Array also in this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If !shouldSubdivide, then useLocalTargetCoords == true. You can see in createPlaneGeometry() that in that case whe use FLoat32Array:
const bufferArray = useLocalTargetCoords ? new Float32Array(12) : new Float64Array(12);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not such a fan of having the useLocalTargetCoords control the transformation to local coordinates in the createPlaneGeometry
function, I think it makes it easier to read when this transformation is explicitly outside of the function, like it was previously with moveTileCenter
, so that it isn't responsible for too many things. But because @FraukeF already approve, I won't block it.
); | ||
|
||
if (!shouldSubdivide) { | ||
return new THREE.Mesh(geometry, material); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not such a fan of having the useLocalTargetCoords control the transformation to local coordinates in the createPlaneGeometry
function, I think it makes it easier to read when this transformation is explicitly outside of the function, like it was previously with moveTileCenter
, so that it isn't responsible for too many things. But because @FraukeF already approve, I won't block it.
It does not include:
Thank you for contributing to harp.gl!
Before requesting a pull request, please remember to check the following documents:
If you are adding new functionality we would highly appreciate if you can describe what is the capability you are adding and even better if you can add some examples. Please also remember to add tests for it.
CI Check
Our bots will check whether your PR can be directly integrated into the mainline. We have some internal integration tests running on the background, our bots will inform you of the next steps and someone from our team will take a look and help if needed!
And please do not forget to sign-off your commit! You can read more about DCO here. But, in short, you just need to use
git commit -s
or append--signoff
when you are committing to the repo.Happy contributing!