HARP-13329: Fix antimeridian cracks on ground planes.

[atomicsulfate]

It does not include:

• Fix for sphere projection.
• Fix for cracks on HERE raster tile source images.

Thank you for contributing to harp.gl!

Before requesting a pull request, please remember to check the following documents:

• contribution guidelines
• coding style

If you are adding new functionality we would highly appreciate if you can describe what is the capability you are adding and even better if you can add some examples. Please also remember to add tests for it.

CI Check

Our bots will check whether your PR can be directly integrated into the mainline. We have some internal integration tests running on the background, our bots will inform you of the next steps and someone from our team will take a look and help if needed!

And please do not forget to sign-off your commit! You can read more about DCO here. But, in short, you just need to use git commit -s or append --signoff when you are committing to the repo.

Happy contributing!

[codecov]

Codecov Report

Merging #2018 (1d92354) into master (628ae16) will increase coverage by 0.15%.
The diff coverage is 97.58%.

@@            Coverage Diff             @@
##           master    #2018      +/-   ##
==========================================
+ Coverage   66.26%   66.41%   +0.15%     
==========================================
  Files         294      297       +3     
  Lines       26313    26336      +23     
  Branches     5930     5939       +9     
==========================================
+ Hits        17435    17492      +57     
+ Misses       8878     8844      -34     

Impacted Files	Coverage Δ
@here/harp-mapview/lib/BoundsGenerator.ts	95.87% <ø> (ø)
...re/harp-mapview/lib/geometry/RegisterTileObject.ts	81.25% <81.25%> (ø)
@here/harp-geometry/lib/SubdivisionModifier.ts	78.49% <100.00%> (+0.47%)	⬆️
@here/harp-mapview/lib/BackgroundDataSource.ts	97.67% <100.00%> (ø)
@here/harp-mapview/lib/geometry/AddGroundPlane.ts	100.00% <100.00%> (ø)
...rp-mapview/lib/geometry/ProjectTilePlaneCorners.ts	100.00% <100.00%> (ø)
...e/harp-mapview/lib/geometry/TileGeometryCreator.ts	70.52% <100.00%> (-0.01%)	⬇️
@here/harp-webtile-datasource/lib/WebTileLoader.ts	100.00% <100.00%> (ø)
... and 4 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 628ae16...1d92354. Read the comment docs.

[atomicsulfate]

@harpgl-bot retest this please

[atomicsulfate]

@harpgl-bot retest this please

[atomicsulfate]

@harpgl-bot retest this please

[nzjony]

You need to convert the Float64Array back to Float32Array also in this case.

[atomicsulfate]

If !shouldSubdivide, then useLocalTargetCoords == true. You can see in createPlaneGeometry() that in that case whe use FLoat32Array:

const bufferArray = useLocalTargetCoords ? new Float32Array(12) : new Float64Array(12);

[nzjony]

I'm not such a fan of having the useLocalTargetCoords control the transformation to local coordinates in the createPlaneGeometry function, I think it makes it easier to read when this transformation is explicitly outside of the function, like it was previously with moveTileCenter, so that it isn't responsible for too many things. But because @FraukeF already approve, I won't block it.

[nzjony]

I'm not such a fan of having the useLocalTargetCoords control the transformation to local coordinates in the createPlaneGeometry function, I think it makes it easier to read when this transformation is explicitly outside of the function, like it was previously with moveTileCenter, so that it isn't responsible for too many things. But because @FraukeF already approve, I won't block it.