Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

Commit

Permalink
HARP-16397 Don't run the test-npm-packages.sh script
Browse files Browse the repository at this point in the history
when releasing, because the script gets confused, it installs dependencies from the current latest package but
then installs the new packages and the peer dependency mismatch causes issues.

I'm not sure if this is what caused the issue as mentioned in the ticket HARP-16397.

Anyway, we need to merge back the release branch to master, and at that point this script will run, so worst case, we can
fix it by doing a patch release.

Signed-off-by: Jonathan Stichbury <[email protected]>
  • Loading branch information
nzjony committed Aug 3, 2021
1 parent b1e7f22 commit b576fd5
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion .github/workflows/deploy_to_npm.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ jobs:
yarn test-cov
yarn karma-headless
yarn karma-headless-firefox
./scripts/test-npm-packages.sh
shell: bash

- name: Build
Expand Down

0 comments on commit b576fd5

Please sign in to comment.