This repository has been archived by the owner on Mar 8, 2023. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
MAPSJS-2983 Write to the console if we need too many attempts getting…
… the image from the cache Some failed attempts is ok, because there are cases where the DataSource is attached and ready and the map has started to render, but the theme isn't fully set. There are other ways to fix the problem, but they are generally more invasive and could introduce regressions, some options are: - In the TileGeometryCreator::createAllGeometries method, await on the getTheme() Promise - Don't allow new TextElements to be added while the theme is updating - Investigate and remove all calls to update the mapview while the method `addDataSource` is called and see if this can be removed, because no update calls means we don't render and request new tiles which may contain references to POI's that don't yet exist on the cache. But, for the sake of simplicity, this is the preferred method. Change-Id: I6243e5fa5cd07ad33343396e2678b4a17d1c6705 Signed-off-by: Jonathan Stichbury <[email protected]>
- Loading branch information