This repository has been archived by the owner on Mar 8, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 197
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
MAPSJS-2983 Write to the console if we need too many attempts getting… (
#2284) Some failed attempts are ok, because there are cases where the DataSource is attached and ready and the map has started to render, but the theme isn't fully set. There are other ways to fix the problem, but they are generally more invasive and could introduce regressions / performance issues, some options are: - In the TileGeometryCreator::createAllGeometries method, await on the getTheme() Promise - Don't allow new TextElements to be added while the theme is updating - Investigate and remove all calls to update the mapview while the method `addDataSource` is called and see if this can be removed, because no update calls means we don't render and request new tiles which may contain references to POI's that don't yet exist on the cache. For the sake of simplicity, this is the preferred method. Signed-off-by: Jonathan Stichbury <[email protected]> Signed-off-by: Fischer, Thomas <[email protected]>
- Loading branch information
Showing
4 changed files
with
113 additions
and
22 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters