Add failOnMissingPlugin option to dslGenerateXml task #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnonnenmacher
suggested changes
May 24, 2018
| @@ -68,6 +68,21 @@ class GenerateXmlTest extends AbstractTaskTest { | |||
| XMLUnit.compareXML(expectedText, actualText).identical() | |||
| } | |||
|
|
|||
| def 'folder is generated incorrectly'() { | |||
There was a problem hiding this comment.
The name is not so telling, what about 'failOnMissingPlugin fails the task if a required plugin is missing'?
There was a problem hiding this comment.
Sounds great, I applied the change.
| ] | ||
| } | ||
|
|
||
| @Option(option = 'failOnMissingPlugin', description = 'Fail the task if the plugin is missing.') |
There was a problem hiding this comment.
'Fail the task if a required plugin is missing.'
mnonnenmacher
approved these changes
May 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the existing option in
dslUpdateJenkins. This pre-verification would be useful to us as we have several Jenkins instances and we maintain a single plugin set.