Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point to flatdata-generator v0.4.6 #246

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

gliderkite
Copy link
Contributor

Updating the version of flatdata-generator (used in fn generate) to 0.4.6 in order to match the one set as dependency requirement

Copy link
Collaborator

@VeaaC VeaaC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. It does require a new release of flatdata-rs to take effect, though.

@VeaaC
Copy link
Collaborator

VeaaC commented Aug 26, 2024

@gliderkite Thanks for fixing this. You still need to sign the changes to indicate that you are ok with transferring copyright. ( see https://github.com/heremaps/flatdata/pull/246/checks?check_run_id=29255190550 ).

@gliderkite gliderkite force-pushed the flatdata-generator-0.4.6 branch from ae2c288 to 50ebea1 Compare August 26, 2024 13:50
@gliderkite
Copy link
Contributor Author

Hi @VeaaC, I signed the commit but I am not authorized to merge the PR. Is there anything else I need to do so that we can merge and release the changes in a new version of the crate? Thanks

@VeaaC VeaaC merged commit a2eba63 into heremaps:master Aug 30, 2024
9 checks passed
@VeaaC
Copy link
Collaborator

VeaaC commented Aug 30, 2024

Thanks @gliderkite , I will release a new version of the crate later today / Monday.

@VeaaC
Copy link
Collaborator

VeaaC commented Aug 30, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants