Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes race when building liblexer_la-lexer.lo #803

Closed
wants to merge 3 commits into from
Closed

fixes race when building liblexer_la-lexer.lo #803

wants to merge 3 commits into from

Conversation

kovac167
Copy link

@kovac167 kovac167 commented Feb 9, 2023 •
edited
Loading

I sporadically saw this error when building in parallel with 64 cpu's.
This change has consistently resolved the issue.

fixes #572

igalic
igalic reviewed Feb 10, 2023
View reviewed changes
Copy link

@igalic igalic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this workaround has been around for five years.

let's commit to it, and call it a fix 👍

@kovac167
Copy link
Author

How do I get this reviewed to merge?

@kovac167 kovac167 closed this by deleting the head repository Jun 25, 2023
@georgehansper
Copy link
Member

This commit which includes this change 565fabd has been added to the master branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igalic igalic igalic left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Race in building liblexer_la-lexer.lo and parser.h
3 participants
@kovac167 @georgehansper @igalic