Remove #include <malloc.h>
#792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhongRuoyu
added a commit
to ZhongRuoyu/homebrew-core
that referenced
this pull request
Dec 13, 2022
Fix submitted upstream at hercules-team/augeas#792.
BrewTestBot
pushed a commit
to Homebrew/homebrew-core
that referenced
this pull request
Dec 13, 2022
* augeas 1.14.0 * augeas: remove patch The patch is now in the release. * augeas: fix build Fix submitted upstream at hercules-team/augeas#792. Closes #118025. Signed-off-by: Dawid Dziurla <[email protected]> Signed-off-by: BrewTestBot <[email protected]>
georgehansper
approved these changes
Dec 14, 2022
|
As it turns out, there is another similar problem affecting FreeBSD and brew, which causes |
|
n.b.: including |
`<malloc.h>` is not present on all platforms (e.g. macOS). `<stdlib.h>` should be the place to look for `malloc`, and it has already been `#include`d. Signed-off-by: Ruoyu Zhong <[email protected]>
This fixes a segfault with `augprint -h` on some non-GNU platforms. See: https://manpages.ubuntu.com/manpages/bionic/en/man3/basename.3.html Signed-off-by: Ruoyu Zhong <[email protected]>
ZhongRuoyu
force-pushed
the
remove-malloc.h
branch
from
6cc785a to
97c137d
Compare
OK, done. Tested locally and confirmed that this is fixed.
Thanks for bringing this up, @igalic. In this case I think it's fine since |
georgehansper
approved these changes
Dec 21, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Submitting this patch to fix the build error in Homebrew/homebrew-core#118025.
<malloc.h>is not present on all platforms (e.g. macOS). To usemalloc,<stdlib.h>should be the place to look formalloc, and it has already been#included.Signed-off-by: Ruoyu Zhong [email protected]