This repository has been archived by the owner on Feb 1, 2022. It is now read-only.
Pre commit #10
Merged
Pre commit #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
bors bot
added a commit
to cachix/git-hooks.nix
that referenced
this pull request
Oct 2, 2019
19: Use the module system r=roberth a=roberth Closes #2 Closes #17 TODO - [x] ~expose and test "core" module set from project.nix~ - [x] ~niv update -b master project.nix when that's done (hercules-ci/project.nix#10 - [x] changelog entry: (elaborate on) translate `.pre-commit-config.yaml` to hooks argument - [x] update README - [x] add how to add a hook to README New - Selectively enable tools (#2) - Make choice of tool versions overridable - User-definable hooks - Input validation at the Nix level - Use gitignore by default Fixes - Stop installing files all over the place when doing nix-shell ../some-project to borrow a tool - Lorri support Cleanup - Get rid of some installation code Co-authored-by: Robert Hensing <[email protected]>
domenkozar
reviewed
Oct 7, 2019
Any problems with auto-install should be addressed in the activation.* options. If it turns out someone needs these, we can reintroduce it. For now, we keep it simple.
domenkozar
approved these changes
Oct 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds pre-commit, shell hooks, activation hooks, nixpkgs-fmt.
I will look into extracting the hook modules into nix-pre-commit-hooks; changing that repo to be compatible with project.nix.
TODO
formatters.nixpkgs-fmtCloses #1