Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shrink inputs footprint further #90

Closed
wants to merge 1 commit into from

Conversation

blaggacao
Copy link

@blaggacao blaggacao commented Dec 24, 2022

13dddfd
reads:

Hopefully lib will be separated into its own flake some day, which
will also make this a much smaller footprint.

Here it is.

/cc @shlevy

hercules-ci@13dddfd
reads:

> Hopefully lib will be separated into its own flake some day, which
> will also make this a much smaller footprint.

Here it is.
@roberth
Copy link
Member

roberth commented Dec 24, 2022

In theory, a github git subtree should be no less efficient than whole repo of equal size.
Nix should implement subdir fetching with the github api as follows. Crucially, the github archive endpoint supports tree hashes.

At lock time

  • look up the tree for a given commit
  • store the git subtree sha
  • fetch the archive for the git subtree sha

At fetch time

  • ignore rev, and fetch the subtree archive

@zimbatm
Copy link
Contributor

zimbatm commented Jan 29, 2023

I think this can be closed since now flake.parts uses github:NixOS/nixpkgs/nixos-unstable?dir=lib as the input

@blaggacao blaggacao closed this Jan 29, 2023
@blaggacao
Copy link
Author

It doesn't mean though the goal of this PR is already achieved since I infer from Robert's comment that this would require upstream changes to Nix.

@roberth roberth mentioned this pull request May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants