Add class: imports "type checking" #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initially this had some feature checking with lib.functionArgs, but I don't think this is useful. The _class attribute is not supported by long-unsupported Nixpkgs (<23.05) anyway, so let's keep it simple.
|
Hi @cdmistman, thanks for reaching out! |
|
ack - haven't gotten to it yet, will get to it this weekend! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might delay a merge as it could lead to something like "unknown option _class" when loading modules from flakes with a (very) recent lib into flakes with an older lib.
Make a tag first?