Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding StorageClasses by default #80

Closed
yuvipanda opened this issue Aug 12, 2017 · 1 comment
Closed

Consider adding StorageClasses by default #80

yuvipanda opened this issue Aug 12, 2017 · 1 comment
Assignees

Comments

@yuvipanda
Copy link

Heya! Following on from jupyterhub/zero-to-jupyterhub-k8s#88 :)

I'd love for there to be a default storage class. Almost all helm charts default to having PVCs that are provisioned by the default, and allow you to override it. I believe this stems from https://kubernetes.io/docs/concepts/storage/persistent-volumes/#writing-portable-configuration, especially:

In the future, we expect most clusters to have DefaultStorageClass enabled, and to have some form of storage available. However, there may not be any storage class names which work on all clusters, so continue to not set one by default. At some point, the alpha annotation will cease to have meaning, but the unset storageClass field on the PVC will have the desired effect.

When writing charts, one very useful attribute is if they can work 'out of the box' with just a helm install with default values - this is actually a requirement for getting them into the stable charts repo. This too only works with a default storage class.

So when following the AWS quickstart, at the end there's additional steps required to get most helm charts to work the way the helm documentation tells you they should work. So people just following the AWS Quickstart and then heading over to helm are a little lost, since there's this missing piece that isn't mentioned here.

In my ideal world, this would come with 4 storage classes (one for each io type), with gp2 set as default. A stop gap might be to add bits about 'you might want to create a storageclass' at the end of the README. However, I think adding the storageclasses as part of the quickstart itself is the right thing to do wrt meeting expectations set by the larger kubernetes community (1 and 2 specifically).

Thank you for the wonderful product and your consideration of this issue!

@rdodev
Copy link

rdodev commented Aug 14, 2017

👍 as stop-gap measure adding a paragraph in the docs about this and how to get around it would be helpful.

//cc @Bradamant3

rosskukulinski added a commit that referenced this issue Oct 7, 2017
rosskukulinski added a commit that referenced this issue Oct 7, 2017
Signed-off-by: Ross Kukulinski <[email protected]>
@timothysc timothysc self-assigned this Oct 17, 2017
rosskukulinski added a commit that referenced this issue Oct 18, 2017
Signed-off-by: Ross Kukulinski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants