Implement EncoderTransformer for both G&D, Training Loop. WIP: gradient regularisation. #34

TairYerniyazov · 2024-10-29T23:26:33Z

Requirements:

AllClusters_1M.dat has to be placed in data/Herwig/raw.
data/Herwig/pids_to_ix.pkl needs to be removed to allow HerwigEventMultiHadronDataset to produce a new PID-to-ID map.

… issues)

hadml/datamodules/components/herwig.py

…dule classes -> WIP. The parser itself has been already tested).

Fix line endings

configs/datamodule/herwig_event_multihadron.yaml

hadml/datamodules/gan_datamodule.py

…dding hadron

configs/experiment/herwig_event_multihadron.yaml

hadml/datamodules/components/herwig.py

hadml/datamodules/gan_datamodule.py

hadml/datamodules/components/herwig.py

hadml/datamodules/gan_datamodule.py

… to OY labels and binning)

…ional stuff making Trainer work

hadml/datamodules/gan_datamodule.py

hadml/metrics/compare_fn.py

remilvus · 2024-12-15T15:01:52Z

hadml/models/cgan/multihadron_event_gan.py

+            preds_kin, preds_types = predictions[:, :4], torch.argmax(predictions[:, 4:], dim=1) - 1
+            truths_kin, truths_types = truths[:, :4], torch.argmax(truths[:, 4:], dim=1) - 1
+
+            # Hadron type histogram


It's often the case that when code follows this pattern:

# <some comment> <multiple lines of code>

The code is easier to follow when the code in obscured with a (private) function

self._some_comment(...)

…enerator

Update data loader (PID-to-IDs map + visualisation)

e485df1

TairYerniyazov requested review from jaychan-hep and remilvus and removed request for jaychan-hep October 29, 2024 23:26

TairYerniyazov added 2 commits November 3, 2024 17:33

Update the data loader (making the code more readable and fixing some…

dbe63b9

… issues)

Small optimisation fixes

3bf2a24

remilvus reviewed Nov 3, 2024

View reviewed changes

hadml/datamodules/components/herwig.py Outdated Show resolved Hide resolved

hadml/datamodules/components/herwig.py Outdated Show resolved Hide resolved

hadml/datamodules/components/herwig.py Outdated Show resolved Hide resolved

remilvus changed the title ~~Update data loader (PID-to-IDs map + visualisation)~~ Update data loader (PID-to-IDs map + visualisation) #WIP Nov 3, 2024

TairYerniyazov and others added 7 commits November 4, 2024 22:24

Add a new Parser class for reading multihadron data (Dataset & Datamo…

3eacf5d

…dule classes -> WIP. The parser itself has been already tested).

Small fix

7c1f2a1

Add a new Lightning Datamodule and update configuration files

b68997d

add .gitatributes

18093bd

fix line endings

41ad457

Fix line endings

71f849e

Merge pull request #35 from hep-lbdl/fix-line-endings

ef2962b

Fix line endings

remilvus reviewed Nov 16, 2024

View reviewed changes

configs/datamodule/herwig_event_multihadron.yaml Outdated Show resolved Hide resolved

hadml/datamodules/gan_datamodule.py Show resolved Hide resolved

hadml/datamodules/gan_datamodule.py Outdated Show resolved Hide resolved

TairYerniyazov added 3 commits November 17, 2024 23:14

Small fixes + adding a separate hadron type (0) for a stop token / pa…

7552d71

…dding hadron

Small fix (get the map needed for old experiments back

29c195c

Optimise data preprocessing, loading and tokenisation

779dee3

TairYerniyazov changed the title ~~Update data loader (PID-to-IDs map + visualisation) #WIP~~ Update data loader (PID-to-IDs map + visualisation) Nov 18, 2024

remilvus requested changes Nov 21, 2024

View reviewed changes

TairYerniyazov added 6 commits November 25, 2024 01:18

Updates and fixes according to Adam's last comments

b4f514a

Small fix

7be1134

Prepare the model template

24f9318

Add plotting methods from previous versions

d45f2e8

Add a Lightning model template, as well as some config files

229bb22

Add a Lightning model template, as well as some config files

1e9ebe4

remilvus reviewed Nov 26, 2024

View reviewed changes

TairYerniyazov added 2 commits November 30, 2024 02:21

Fix the overhead related to runtime warnings

e877113

Update the visualisation method (4 charts on the same diagram + fixes…

4a033dc

… to OY labels and binning)

TairYerniyazov added 4 commits November 30, 2024 21:19

Updates to Adam's last comments

fd41edc

Replace a triple list with a list of dataclass objects

983eae4

Update configs, add methods needed for evaluation diagrams, fix addit…

9b5fc38

…ional stuff making Trainer work

Fix the Scott's normal reference rule function

1dd0ccb

remilvus reviewed Dec 5, 2024

View reviewed changes

hadml/datamodules/gan_datamodule.py Outdated Show resolved Hide resolved

hadml/metrics/compare_fn.py Outdated Show resolved Hide resolved

TairYerniyazov added 3 commits December 11, 2024 19:40

Add visualisation (evaluation loop), update configuration files

257f16f

Add visualisation of clusters and quarks as part of the sanity check

5975bbc

Add visualisation of sentence statistics

f3930be

remilvus approved these changes Dec 15, 2024

View reviewed changes

Add implemented encoder-only transformers for the discriminator and g…

6c95538

…enerator

TairYerniyazov changed the title ~~Update data loader (PID-to-IDs map + visualisation)~~ Implement EncoderTransformer for both G&D (WIP: training loop) Dec 22, 2024

TairYerniyazov added 2 commits December 22, 2024 18:07

Remove the DecoderTransformer template

164a5b0

Add the GAN training loop

73a660c

TairYerniyazov changed the title ~~Implement EncoderTransformer for both G&D (WIP: training loop)~~ Implement EncoderTransformer for both G&D, Training Loop. WIP: gradient regularisation. Dec 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement EncoderTransformer for both G&D, Training Loop. WIP: gradient regularisation. #34

Implement EncoderTransformer for both G&D, Training Loop. WIP: gradient regularisation. #34

TairYerniyazov commented Oct 29, 2024

remilvus Dec 15, 2024

Implement EncoderTransformer for both G&D, Training Loop. WIP: gradient regularisation. #34

Are you sure you want to change the base?

Implement EncoderTransformer for both G&D, Training Loop. WIP: gradient regularisation. #34

Conversation

TairYerniyazov commented Oct 29, 2024

remilvus Dec 15, 2024

Choose a reason for hiding this comment