Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to new version of lightning. #31

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Upgrade to new version of lightning. #31

wants to merge 4 commits into from

Conversation

xju2
Copy link
Collaborator

@xju2 xju2 commented Apr 2, 2024

Move our package hadml to the src folder to prevent a mixture of locally installed and the dev version. Now you need to install the package to use it. The environment for testing the code is shown as follows:

.venv) [xju@login38] hadml >./scripts/check_env.py 
python interpreter: /pscratch/sd/x/xju/Herwig/hadml/.venv/bin/python
python version: 3.11.7 | packaged by conda-forge | (main, Dec 23 2023, 14:43:09) [GCC 12.3.0]
torch:  2.2.2+cu121
torch cuda:  True
torch cuda device count:  1
torch cuda device name:  NVIDIA A100-PCIE-40GB
torch cuda device capability:  (8, 0)
torch distributed     : True
lightning:  2.2.1
pyg:  2.5.2
torch_scatter:  2.1.2+pt22cu121
Test scatter_max in cuda.
out: tensor([[0, 0, 4, 3, 2, 0],
        [2, 4, 3, 0, 0, 0]], device='cuda:0')
argmax: tensor([[5, 5, 3, 4, 0, 1],
        [1, 4, 3, 5, 5, 5]], device='cuda:0')

I gave up the idea of conda environment and embraced the .venv, which can be easily created in VScode.

We may miss some exemplary input data for running the examples. We should put some small data into the data folder so that we can easily test if "old" training works.

@xju2 xju2 requested review from jaychan-hep and remilvus and removed request for jaychan-hep April 2, 2024 23:10
@@ -10,38 +10,27 @@ The original README.md is moved to [`tests/README.md`](tests/README.md).
git clone [email protected]:hep-lbdl/hadml.git
cd hadml

# [OPTIONAL] create conda environment
conda create -n herwig python=3.9
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should still have this command, so that it's obvious which python version should have all the correct versions of dependencies available?

@@ -5,4 +5,4 @@ pin_memory: False
core_dataset:
_target_: hadml.datamodules.components.herwig.Herwig
data_dir: "${paths.data_dir}Herwig"
train_val_test_split: [0.96, 0.02, 0.02]
train_val_test_split: [80, 10, 10]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change it to [800, 100, 100]? It's not very important, but this way it would be clear those aren't percentage points

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants