-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to new version of lightning. #31
base: main
Are you sure you want to change the base?
Conversation
@@ -10,38 +10,27 @@ The original README.md is moved to [`tests/README.md`](tests/README.md). | |||
git clone [email protected]:hep-lbdl/hadml.git | |||
cd hadml | |||
|
|||
# [OPTIONAL] create conda environment | |||
conda create -n herwig python=3.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should still have this command, so that it's obvious which python version should have all the correct versions of dependencies available?
@@ -5,4 +5,4 @@ pin_memory: False | |||
core_dataset: | |||
_target_: hadml.datamodules.components.herwig.Herwig | |||
data_dir: "${paths.data_dir}Herwig" | |||
train_val_test_split: [0.96, 0.02, 0.02] | |||
train_val_test_split: [80, 10, 10] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we change it to [800, 100, 100]
? It's not very important, but this way it would be clear those aren't percentage points
Move our package
hadml
to thesrc
folder to prevent a mixture of locally installed and the dev version. Now you need to install the package to use it. The environment for testing the code is shown as follows:I gave up the idea of
conda
environment and embraced the.venv
, which can be easily created in VScode.We may miss some exemplary input data for running the examples. We should put some small data into the data folder so that we can easily test if "old" training works.