Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default electron version and remove crash reporter #48

Merged
merged 2 commits into from
Jul 7, 2016
Merged

Update default electron version and remove crash reporter #48

merged 2 commits into from
Jul 7, 2016

Conversation

keslerm
Copy link
Contributor

@keslerm keslerm commented Jul 7, 2016

These two things fixed my issues with the blank window (see #33)

By default it was installing an older version of electron which seems to be causing some problems.

I am now able to build and run it as expected.

@henryboldi henryboldi merged commit 71870ea into henryboldi:master Jul 7, 2016
@henryboldi
Copy link
Owner

Excellent, thanks! 💓

@brbsix
Copy link

brbsix commented Jul 8, 2016

package.json needs to be updated for this to work (brbsix@a880bf6)

Also, there's one other reference to crashReporter at the top of main.development.js that should probably be removed (brbsix@fb7950e).

@greg-js
Copy link
Contributor

greg-js commented Jul 8, 2016

Yep, I was wondering why the clean rebuild I just made suddenly gave me a blank screen again. Made a quick PR myself rather than wait since it affects a lot of people and should get sorted asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants