Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error messages #12

Open
laszlokorte opened this issue Jul 4, 2016 · 2 comments
Open

Error messages #12

laszlokorte opened this issue Jul 4, 2016 · 2 comments
Assignees
@frankcash
Labels
bug enhancement hacktoberfest help wanted
Milestone
Generate 2nd Release

Comments

@laszlokorte
Copy link

When entering invalid public keys, signed messages or encrypted messages it just does nothing. An error message should be displayed.
@henryboldi
Copy link
Owner

Agreed. I would love a PR 😺

@sleepypikachu
Copy link

https://github.com/henryboldi/felony/blob/master/app/actions/KeychainActions.js#L10
https://github.com/henryboldi/felony/blob/master/app/actions/KeychainActions.js#L25
https://github.com/henryboldi/felony/blob/master/app/actions/AliasesActions.js#L12
https://github.com/henryboldi/felony/blob/master/app/actions/AliasesActions.js#L27
https://github.com/henryboldi/felony/blob/master/package.js#L96
https://github.com/henryboldi/felony/blob/master/main.development.js#L43

Are all the places where an error is caught and silently logged/ignored. I'll probably submit a PR later today, leaving this here for my reference (or someone to snipe me with 🎯)

@frankcash frankcash added the bug label Aug 4, 2016
@frankcash frankcash self-assigned this Aug 4, 2016
@frankcash frankcash added this to the Generate 2nd Release milestone Aug 9, 2016
@frankcash frankcash mentioned this issue Aug 9, 2016
Open
frankcash pushed a commit that referenced this issue Aug 17, 2016
Adds some logging (#12)
c1a657e
frankcash pushed a commit that referenced this issue Aug 17, 2016
Updates CONTRIBUTING.md to include log file (#12)
dc0115f
greg-js pushed a commit to greg-js/felony that referenced this issue Sep 22, 2016
@greg-js
Adds some logging (henryboldi#12)
2329b81
greg-js pushed a commit to greg-js/felony that referenced this issue Sep 22, 2016
@greg-js
Updates CONTRIBUTING.md to include log file (henryboldi#12)
efa88fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frankcash frankcash

Labels
bug enhancement hacktoberfest help wanted
Projects
None yet
Milestone
Generate 2nd Release
Development

No branches or pull requests
4 participants
@laszlokorte @sleepypikachu @henryboldi @frankcash