Formatting durations fix, and pretty printing cleanup #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the stdlib's duration formatting function rather than hand rolling something and dealing with possible bugs. Refactored the pretty printing function a bit to allow for monochrome output more easily as well.
bens
force-pushed
the
format-fractions
branch
5 times, most recently
from
035ca22
to
b06e3a5
Compare
|
Thanks 🙏 looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the stdlib's duration formatting function rather than hand rolling something and dealing with possible bugs. Refactored the pretty printing function a bit to allow for monochrome output more easily as well.